Skip to content

Update to latest gateway-messages / shipping faux-mgs #7666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jgallagher
Copy link
Contributor

No description provided.

sensor == "CPU" && target.component_kind == "sbtsi";
let is_tctl = (sensor == "CPU"
&& target.component_kind == "sbtsi")
|| m.kind == MeasurementKind::CpuTctl;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hawkw Is this change right? I'm wondering if we need to continue supporting "temperator + CPU + sbtsi is really cpu tctl" now that we have an explicit enum variant for it (and would like a double-check that this new variant should be treated this way!). Maybe it depends on what SP versions we assume we're talking to?

@@ -131,7 +131,7 @@ toml_edit-3c51e837cfc5589a = { package = "toml_edit", version = "0.22.24", featu
tracing = { version = "0.1.40", features = ["log"] }
usdt = { version = "0.5.0" }
usdt-impl = { version = "0.5.0", default-features = false, features = ["asm", "des"] }
uuid = { version = "1.12.0", features = ["serde", "v4"] }
uuid = { version = "1.15.1", features = ["serde", "v4"] }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunshowers I was surprised when I tried to update gateway-sp-messages (which itself keeps pretty regularly up to date on dependencies) that I had to manually cargo update -p ... a handful of packages (all of which are noted in diffs to this file). When I did that, I also got a note from cargo that we have many dependencies that are behind:

note: pass `--verbose` to see 192 unchanged dependencies behind latest

If this is all expected and working as intended, sorry for the noise! It just caught me off guard; I thought renovate was keeping us more up to date than it appears to be (e.g., the last renovate PR for uuid was #7070, since which there have been 7 newer versions published). Should I be less eager to merge dep updates in the MGS repo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renovate has a max limit of 10 PRs per repo -- so those rate limits have been kicking in.

@jgallagher
Copy link
Contributor Author

Closing in favor of #7924

@jgallagher jgallagher closed this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants