Skip to content

Conversation

zeeshanlakhani
Copy link
Collaborator

@zeeshanlakhani zeeshanlakhani commented Jul 10, 2024

Related to #6018, but without the CI/xtask bits.

Copy link
Contributor

@david-crespo david-crespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes my problem. See #6018 (comment)

Copy link
Collaborator

@bnaecker bnaecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! One question, not a blocker. Thanks for splitting this out, makes a lot of sense while you continue to figure out the best path on CI feature-checking.

@zeeshanlakhani zeeshanlakhani enabled auto-merge (squash) July 10, 2024 18:48
@zeeshanlakhani zeeshanlakhani merged commit 808b1a1 into main Jul 10, 2024
@zeeshanlakhani zeeshanlakhani deleted the zl/feature-fixes branch July 10, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants