Blueprint planner: add support for sled evacuation (PR 3/3) - #11306
Open
jgallagher wants to merge 9 commits into
Open
jgallagher wants to merge 9 commits into
jgallagher wants to merge 9 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sled evacuation is disabled by default (due to the default policy set up in the #11304, the first PR in this stack). It can be enabled via the normal
omdbmachinery to update the reconfigurator config, and once all the other related work lands, we can change the default.Sorry for the size of this PR, but in practice it's much smaller than the stats here claim. If we filter out EXPECTORATE-produced files, the stats are
and of that, well over half is test-only code (new tests, updates to old tests, or test support changes). If this is still too big, I'm open to suggestions of additional things to break out.
Some of the expectorate files are still worth reviewing, particularly the new reconfigurator-cli test (
cmds-sled-evacuation-stdout) and the updates to the simulated full-system update (cmds-target-release-stdout). I've read over those and believe everything is working as intended, but please confirm!