Repository navigation
Check for default subnet (not just VPC) when creating an instance - #3425
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
charliepark
changed the title
fakemonster
approved these changes
Oct 26, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a project doesn't have a
defaultVPC anddefaultsubnet — that is, with the literal namedefault, not just marked as the default VPC/subnet — the instance creation process will have trouble if the user has selected the default networking option. Currently, we DO check to make sure there's adefaultVPC, but we aren't checking for thedefaultsubnet.This PR updates that check so that both the VPC and subnet are required. If they aren't both present, the user can't pick the default NIC.
This is probably a pretty edge case, as the likelihood that someone HAS a
defaultVPC (which we currently check for) but NOT adefaultsubnet is pretty low — they would have had to change just the subnet's name away fromdefault. But it seems like a straightforward thing to check for.