lib: Remove attrs and clean up handling of entry. #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daym
force-pushed
the
issue-18
branch
11 times, most recently
from
16455ee to
95b8018
Compare
daym
changed the title
Merged
dancrossnyc
reviewed
Aug 12, 2022
dancrossnyc
reviewed
Aug 12, 2022
dancrossnyc
reviewed
Aug 12, 2022
dancrossnyc
reviewed
Aug 12, 2022
dancrossnyc
reviewed
Aug 12, 2022
dancrossnyc
reviewed
Aug 12, 2022
dancrossnyc
reviewed
Aug 12, 2022
|
Did the changes on top of issue-8 ( #20 ) because it's easier than to rebase. |
ok. In that case, I think that one is ready to go in. |
dancrossnyc
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18.