ci: move tests/clippy to GH workflows

[dancrossnyc]

No description provided.

[jclulow]

What's the goal here? I think we should continue to run the tests on Helios?

[dancrossnyc]

Just slimming things down.

We exercise this on helios via buildomat through amd-host-image-bulider; it seems wasteful of limited buildomat resources to also do amd-efs specifically there (granted, this is pretty small), especially since there's nothing illumos specific in here.

[jclulow]

We're not constrained on the buildomat resources this is using, though, just on the bare metal machines that things like control plane integration tests use. I'd much rather we discover an issue here, rather than in the CI for another repository.

[dancrossnyc]

We're not constrained on the buildomat resources this is using, though, just on the bare metal machines that things like control plane integration tests use. I'd much rather we discover an issue here, rather than in the CI for another repository.

I don't know what issues we would discover through buildomat that we wouldn't similarly discover in the GH workflow. This is just a library, and not one that exercises the system in a particularly weird way where we'd expect to see any helios-specific issues.