Skip to content

amd-efs#99 Improve dumping of image contents with unknown parts. #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

daym
Copy link
Collaborator

@daym daym commented Nov 14, 2023

See #99

@daym daym requested a review from luqmana November 14, 2023 18:16
@daym
Copy link
Collaborator Author

daym commented Nov 14, 2023

Not sure whether serde can be coaxed to continue even on serialization failure--and maybe even set a flag and fall back to something safe in that case.

Could always implement our own custom Serializer, I guess. It could just serialize the entire Result on each field, for example.

@daym
Copy link
Collaborator Author

daym commented Nov 28, 2023

We do implement our own serializer now (in amd-host-image-builder). It works just fine that way.

@daym daym marked this pull request as ready for review November 28, 2023 00:24
@daym daym force-pushed the issue-99 branch 2 times, most recently from eeb0537 to 0b1cc38 Compare November 28, 2023 01:13
@wesolows wesolows removed their request for review March 12, 2024 20:27
@wesolows
Copy link

Please don't wait for me; I don't understand this code and can't review it effectively. You have 2 capable reviewers already so if this checks out it can land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants