Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(oxc_release.toml): add crates/oxc_language_server/Cargo.toml #8703

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

re-taro
Copy link
Contributor

@re-taro re-taro commented Jan 25, 2025

close #8603

Add crates/oxc_language_server/Cargo.toml to release LS with linter's release

Copy link

graphite-app bot commented Jan 25, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Jan 25, 2025
@Boshen
Copy link
Member

Boshen commented Jan 25, 2025

This is not the correct fix. This file is used for publishing crates.

We need to find where the language server version: "0.0.1" value is set, and set it correctly when we build the binary in CI.

@re-taro
Copy link
Contributor Author

re-taro commented Jan 25, 2025

This is not the correct fix. This file is used for publishing crates.

We need to find where the language server version: "0.0.1" value is set, and set it correctly when we build the binary in CI.

Oops, my bad. I'll fix it.

@re-taro re-taro marked this pull request as draft January 25, 2025 10:02
@re-taro
Copy link
Contributor Author

re-taro commented Jan 25, 2025

Hmmm, there appears to be no problem with the implementation.

info!("language server version: {:?}", env!("CARGO_PKG_VERSION"));

It is thought that this will change if the version of oxc_language_server is also upgraded and built according to the release of oxlint...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oxc_language server still on version 0.0.1
2 participants