fix(linter): can't disable no-nested-ternary rule anymore
#8600
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
CodSpeed Performance ReportMerging #8600 will not alter performanceComparing Summary
|
| @@ -465,9 +469,8 @@ mod test { | |||
| fn test_override_plugin_prefix_duplicates() { | |||
| let configs = [ | |||
| // FIXME: this should be valid | |||
| // json!({ "@typescript-eslint/no-unused-vars": "error" }), | |||
| json!({ "no-unused-vars": "off", "typescript/no-unused-vars": "error" }), | |||
| json!({ "no-unused-vars": "off", "@typescript-eslint/no-unused-vars": "error" }), | |||
There was a problem hiding this comment.
@typescript-eslint/no-unused-vars does not exist.
There was a problem hiding this comment.
here is the rule: https://typescript-eslint.io/rules/no-unused-vars/
Internally we are remapping some eslint rules to typescript here:
oxc/crates/oxc_linter/src/utils/mod.rs
Lines 55 to 74 in d966e0a
There was a problem hiding this comment.
Internally we are remapping some eslint rules to typescript here:
Got it.
| json!({ "no-unused-vars": "off", "typescript/no-unused-vars": "error" }), | ||
| json!({ "no-unused-vars": "off", "@typescript-eslint/no-unused-vars": "error" }), | ||
| // json!({ "@unicorn-eslint/no-nested-ternary": "error" }), | ||
| json!({ "no-nested-ternary": "off", "unicorn/no-nested-ternary": "error" }), |
There was a problem hiding this comment.
"no-nested-ternary" => "eslint/no-nested-ternary"
Currently, we do not support rules without an explicit plugin_name, which would automatically match all rules:
"no-nested-ternary" => "eslint/no-nested-ternary" and "unicorn/no-nested-ternary"
closes #8485
Since we currently support rules with the same
namebut differentplugins, some of the original logic is no longer applicable. As a result, I have made some adjustments.