Skip to content

Conversation

@connorshea
Copy link
Collaborator

This will hopefully ensure we don't miss changes in the future for oxlint-migrate.

This will hopefully ensure we don't miss changes in the future for oxlint-migrate.
@connorshea connorshea requested a review from camc314 as a code owner November 16, 2025 08:55
Copilot AI review requested due to automatic review settings November 16, 2025 08:55
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 16, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 16, 2025
Copilot finished reviewing on behalf of connorshea November 16, 2025 08:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation comments to constant arrays in the linter utils module to remind developers to update the oxlint-migrate project when modifying these rule lists. The changes improve maintainability by reducing the risk of desynchronization between the two codebases.

  • Added doc comments with references to oxlint-migrate for VITEST_COMPATIBLE_JEST_RULES and TYPESCRIPT_COMPATIBLE_ESLINT_RULES constants
  • Fixed capitalization: "Typescript" → "TypeScript" and "Eslint" → "ESLint"
  • Included GitHub URLs pointing to the corresponding constants in the oxlint-migrate repository

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 16, 2025

CodSpeed Performance Report

Merging #15741 will not alter performance

Comparing migrate-links (39a5d48) with main (1f09d3c)

Summary

✅ 4 untouched
⏩ 33 skipped1

Footnotes

  1. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@connorshea connorshea changed the title chore(linter): Add docs back to the oxlint-migrate codebase. chore(linter): Add links pointing back to the oxlint-migrate codebase. Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants