feat!: Improved Plugin #130
Conversation
Handles yarn, pnpm, and WSL settings to support different development setups
|
Thanks for the PR! I’m hoping to review it sometime this week. |
There was a problem hiding this comment.
The only concern I have is that I can't seem to find the sources for classes such as NodePackageDescriptor. I think this is expected, but without documentation I think it might be difficult for contributors outside of JetBrains to maintain code that interacts with these classes.
Are these sources available somewhere?
Aside from that, I left a few comments.
src/main/kotlin/com/github/oxc/project/oxcintellijplugin/services/OxcServerService.kt
Outdated
Show resolved
Hide resolved
| settings.supportedExtensions = | ||
| value.split(",").map { it.trim() }.filter { it.isNotBlank() }.toMutableList() | ||
| }).validationOnInput { validateExtensions(it) }.applyToComponent { | ||
| font = font.deriveFont(font.size2D - 2f) // Reduce font size by 2 points |
There was a problem hiding this comment.
I feel like the font is kind of small, but it can probably be left alone for now.
There was a problem hiding this comment.
I agree, but I don’t have a better idea. We can try another font or control if it doesn’t work for us
| key="oxc.name" | ||
| /> | ||
| <actionOnSaveInfoProvider id="OxcOnSaveInfoProvider" | ||
| implementation="com.github.oxc.project.oxcintellijplugin.settings.OxcOnSaveInfoProvider" | ||
| order="after FormatOnSaveInfoProvider, after EsLintOnSaveInfoProvider, before FileWatcherOnSaveInfoProvider, before UploadOnSaveInfoProvider"/> |
There was a problem hiding this comment.
The general recommendation for Oxlint CLI usage is to execute Oxlint first and then ESLint. Is there any reason the on save action should be different?
There was a problem hiding this comment.
actionOnSaveInfoProvider refers to the order in the table on the ‘On Save Action’ tab.
I guess it can be anything, but I wanted to keep them as close as possible to ESLint.
I'm seeing the same thing with some of the testing I did. Will need to look at it on the language server side. |
Refactored `getServer` in `OxcServerService` to simplify type handling, removing a redundant cast. Also, reformatted `plugin.xml` for better readability and consistency. Removed the `gradleJvm` setting from Gradle configuration.
This PR adds support for Yarn, PNPM, WSL, and workspaces, improves the plugin’s settings window (now offering auto, manual, and disabled modes), and introduces an option to apply quick fixes on file save.
It’s strange that, for some reason, I only got an only ignore quick fix (even in VSCode) for the diagnostic
