Skip to content

Commit

Permalink
ci: Exclude tests that show random failures through GitHub actions.
Browse files Browse the repository at this point in the history
I ran 80 series of full tests, and the following tests showed failures:

 802.1ad - vlan_limit
   +2023-11-20T10:32:11.245Z|00001|dpif_netdev(revalidator5)|ERR|internal
     error parsing flow key recirc_id(0),dp_hash(0),skb_priority(0),
     in_port(2),skb_mark(0),ct_state(0),ct_zone(0),ct_mark(0),ct_label(0),
     packet_type(ns=0,id=0),eth(src=42:7e:4b:46:68:1b,dst=33:33:ff:46:68:1b),
     eth_type(0x88a8),vlan(vid=4094,pcp=0),encap(eth_type(0x8100),
     vlan(vid=100,pcp=0),encap(eth_type(0x86dd),ipv6(
     src=::,dst=ff02::1:ff46:681b,label=0,proto=58,tclass=0,hlimit=255,
     frag=no),icmpv6(type=135,code=0),nd(target=fe80::407e:4bff:fe46:681b,
     sll=00:00:00:00:00:00,tll=00:00:00:00:00:00)))
   +2023-11-20T10:32:11.245Z|00002|dpif(revalidator5)|WARN|netdev@ovs-netdev:
     failed to put[modify] (Invalid argument)
     ufid:ef1ca90c-dbd0-4ca7-9869-411bdffd1ece recirc_id(0),dp_hash(0/0),
     skb_priority(0/0),in_port(2),skb_mark(0/0),ct_state(0/0),ct_zone(0/0),
     ct_mark(0/0),ct_label(0/0),packet_type(ns=0,id=0),
     eth(src=42:7e:4b:46:68:1b,dst=33:33:ff:46:68:1b),eth_type(0x88a8),
     vlan(vid=4094,pcp=0/0x0),encap(eth_type(0x8100),
     vlan(vid=100/0x0,pcp=0/0x0),encap(eth_type(0x86dd),
     ipv6(src=::/::,dst=ff02::1:ff46:681b/::,label=0/0,proto=58/0,
     tclass=0/0,hlimit=255/0,frag=no),icmpv6(type=135/0,code=0/0),
     nd(target=fe80::407e:4bff:fe46:681b/::,
     sll=00:00:00:00:00:00/00:00:00:00:00:00,
     tll=00:00:00:00:00:00/00:00:00:00:00:00))), actions:drop

  conntrack - zones from other field, more tests
    +2023-11-20T10:45:43.015Z|00001|dpif(handler5)|WARN|system@ovs-system:
      execute ct(commit),3 failed (Invalid argument) on packet tcp,
      vlan_tci=0x0000,dl_src=42:7e:4b:46:68:1b,dl_dst=ba:72:4c:a5:31:6b,
      nw_src=10.1.1.1,nw_dst=10.1.1.2,nw_tos=0,nw_ecn=0,nw_ttl=64,
      nw_frag=no,tp_src=53738,tp_dst=80,tcp_flags=psh|ack tcp_csum:e4a

  conntrack - limit by zone
    ./system-traffic.at:5154: ovs-appctl dpctl/ct-get-limits zone=0,1,2,3,4,5
    --- -	2023-11-20 10:51:09.965375141 +0000
    +++ /home/runner/work/ovs/ovs/tests/system-kmod-testsuite.dir/at-groups/
      114/stdout	2023-11-20 10:51:09.956723756 +0000
    @@ -1,5 +1,5 @@
     default limit=10
    -zone=0,limit=5,count=5
    +zone=0,limit=5,count=6

As I do not see those failures when running these stand alone on the
same Ubuntu distribution, I've disabled them.

This patch also adds the 'CHECK_GITHUB_ACTION' macro to skip
tests that won't execute successfully through GitHub actions.
We could not use the -k !keyword option, as it can not be
combined with a range of tests.

Signed-off-by: Eelco Chaudron <[email protected]>
Reviewed-by: Simon Horman <[email protected]>
Signed-off-by: 0-day Robot <[email protected]>
  • Loading branch information
chaudron authored and ovsrobot committed Dec 19, 2023
1 parent 19cc0c5 commit fc9f8dd
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
4 changes: 4 additions & 0 deletions tests/system-common-macros.at
Original file line number Diff line number Diff line change
Expand Up @@ -365,3 +365,7 @@ m4_define([OVS_CHECK_IPROUTE_ENCAP],
# OVS_CHECK_CT_CLEAR()
m4_define([OVS_CHECK_CT_CLEAR],
[AT_SKIP_IF([! grep -q "Datapath supports ct_clear action" ovs-vswitchd.log])])

# OVS_CHECK_GITHUB_ACTION
m4_define([OVS_CHECK_GITHUB_ACTION],
[AT_SKIP_IF([test "$GITHUB_ACTIONS" = "true"])])
3 changes: 3 additions & 0 deletions tests/system-traffic.at
Original file line number Diff line number Diff line change
Expand Up @@ -3311,6 +3311,7 @@ AT_CLEANUP

AT_SETUP([conntrack - zones from other field, more tests])
CHECK_CONNTRACK()
OVS_CHECK_GITHUB_ACTION()
OVS_TRAFFIC_VSWITCHD_START()

ADD_NAMESPACES(at_ns0, at_ns1)
Expand Down Expand Up @@ -5270,6 +5271,7 @@ AT_CLEANUP

AT_SETUP([conntrack - limit by zone])
CHECK_CONNTRACK()
OVS_CHECK_GITHUB_ACTION()
OVS_TRAFFIC_VSWITCHD_START()

ADD_NAMESPACES(at_ns0, at_ns1)
Expand Down Expand Up @@ -8099,6 +8101,7 @@ AT_CLEANUP
AT_BANNER([802.1ad])

AT_SETUP([802.1ad - vlan_limit])
OVS_CHECK_GITHUB_ACTION()
OVS_TRAFFIC_VSWITCHD_START([set Open_vSwitch . other_config:vlan-limit=0])
OVS_CHECK_8021AD()

Expand Down

0 comments on commit fc9f8dd

Please sign in to comment.