ovsdb-server: Do not use filename after free.

Scanhub reported the following splat:

3. ovsdb/ovsdb-server.c:505:5:
    freed_arg: "shash_replace_nocopy" frees "filename".
6. ovsdb/ovsdb-server.c:507:9:
    pass_freed_arg: Passing freed pointer "filename" as an argument to
    "vlog".

In all code paths with a duplicate configuration, OVSDB would print a
warning log message using a freed pointer. Now, the original option is
used.

Reported-at: https://issues.redhat.com/browse/FDP-1118
Signed-off-by: Mike Pattrick <[email protected]>
Signed-off-by: 0-day Robot <[email protected]>

ovsdb/ovsdb-server.c

@@ -504,7 +504,7 @@ add_database_config(struct shash *db_conf, const char *opt,
 
     conf = shash_replace_nocopy(db_conf, filename, conf);
     if (conf) {
-        VLOG_WARN("Duplicate database configuration: %s", filename);
+        VLOG_WARN("Duplicate database configuration: %s", opt);
         db_config_destroy(conf);
     }
 }