ofproto: Fix potential NULL pointer dereference in ofproto_type_xx().

Ensure a valid class is found before calling it's function pointer. Signed-off-by: Eelco Chaudron <[email protected]> Signed-off-by: 0-day Robot <[email protected]>
ovsrobot · Feb 5, 2025 · 2c8b28e · 2c8b28e
1 parent b663309
commit 2c8b28e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
@@ -1897,7 +1897,7 @@ ofproto_type_run(const char *datapath_type)
     datapath_type = ofproto_normalize_type(datapath_type);
     class = ofproto_class_find__(datapath_type);
 
-    error = class->type_run ? class->type_run(datapath_type) : 0;
+    error = (class && class->type_run) ? class->type_run(datapath_type) : 0;
     if (error && error != EAGAIN) {
         VLOG_ERR_RL(&rl, "%s: type_run failed (%s)",
                     datapath_type, ovs_strerror(error));
@@ -1913,7 +1913,7 @@ ofproto_type_wait(const char *datapath_type)
     datapath_type = ofproto_normalize_type(datapath_type);
     class = ofproto_class_find__(datapath_type);
 
-    if (class->type_wait) {
+    if (class && class->type_wait) {
         class->type_wait(datapath_type);
     }
 }