ofproto: Fix potential NULL pointer dereference in ofproto_type_xx().

Ensure a valid class is found before calling it's function pointer. If it's not found, call ovs_assert(). Signed-off-by: Eelco Chaudron <[email protected]> Signed-off-by: 0-day Robot <[email protected]>
ovsrobot · Feb 6, 2025 · 15bb0ce · 15bb0ce
1 parent 0f8e5c2
commit 15bb0ce
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
@@ -1896,6 +1896,7 @@ ofproto_type_run(const char *datapath_type)
 
     datapath_type = ofproto_normalize_type(datapath_type);
     class = ofproto_class_find__(datapath_type);
+    ovs_assert(class);
 
     error = class->type_run ? class->type_run(datapath_type) : 0;
     if (error && error != EAGAIN) {
@@ -1912,6 +1913,7 @@ ofproto_type_wait(const char *datapath_type)
 
     datapath_type = ofproto_normalize_type(datapath_type);
     class = ofproto_class_find__(datapath_type);
+    ovs_assert(class);
 
     if (class->type_wait) {
         class->type_wait(datapath_type);