Skip to content

Conversation

@guess-burger
Copy link

…but still supporting the original message format passed to handlers.

There now two kinds of subscriptions:

  • :clj-gcp.pub-sub.core/subscriber
    • produces a message which is a map with the keys :pubsub/ack-id, :pubsub/attributes and the new :pubsub/payload which is the UTF-8 value of the notification.
  • :clj-gcp.pub-sub.core/notification-subscriber
    • produces a message in the "notification" format previous used by :clj-gcp.pub-sub.core/subscriber which involved json decoding the message payload and merging the attributes and ack-id into the result in map

Existing users of the library should be able to just change to use :clj-gcp.pub-sub.core/notification-subscriber.

N.B. this has not been extensively integration tested

@GavinEsbergerOVO
Copy link
Contributor

Checked this morning and the integration test pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants