Skip to content

Conversation

@Tsiorifamonjena
Copy link
Contributor

Description

Ticket Reference: #TAPC-4623, #TAPC-4626

Additional Information

image image

@Tsiorifamonjena Tsiorifamonjena force-pushed the feat/pci-instances-creation-list-ssh-key branch from 0c42d6e to 337021d Compare November 7, 2025 13:12
@Tsiorifamonjena Tsiorifamonjena marked this pull request as ready for review November 7, 2025 13:12
@Tsiorifamonjena Tsiorifamonjena requested a review from a team as a code owner November 7, 2025 13:13
@Tsiorifamonjena Tsiorifamonjena force-pushed the feat/pci-instances-creation-list-ssh-key branch from 337021d to f1d0fbd Compare November 7, 2025 13:26
@Tsiorifamonjena Tsiorifamonjena force-pushed the feat/pci-instances-creation-list-ssh-key branch from 47f7b1a to 5bd8799 Compare November 7, 2025 13:43
@Tsiorifamonjena Tsiorifamonjena marked this pull request as draft November 7, 2025 15:42
@Tsiorifamonjena Tsiorifamonjena force-pushed the feat/pci-instances-creation-list-ssh-key branch from 5bd8799 to dbc4191 Compare November 7, 2025 16:24
@Tsiorifamonjena Tsiorifamonjena marked this pull request as ready for review November 7, 2025 16:33
@Tsiorifamonjena Tsiorifamonjena force-pushed the feat/pci-instances-creation-list-ssh-key branch from dbc4191 to 27376fc Compare November 7, 2025 16:39
Copy link
Contributor

@lolottetheclash lolottetheclash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should improve the SSH key regex: it should not valid the fact that it can contain some blank spaces into the ssh key, and also you should trim it before testing it

Comment on lines 92 to 102
useEffect(() => {
if (!isLoading) setSshKeyItems(sshKeys);
}, [isLoading, sshKeys]);

useEffect(() => {
if (!isLoading && sshKeys.length === 0) setOpenSshKeyForm(true);
}, [isLoading, sshKeys]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can merge those two use effect (same dependencies)

@Tsiorifamonjena Tsiorifamonjena force-pushed the feat/pci-instances-creation-list-ssh-key branch from 27376fc to b4ff286 Compare November 12, 2025 13:24
@Tsiorifamonjena Tsiorifamonjena marked this pull request as draft November 12, 2025 13:30
@lolottetheclash
Copy link
Contributor

@Tsiorifamonjena I was thinking that ssh key should not contain any blank space but I think it's wrong, it can contain between each part. To trim it is a good practise, but maybe check the right ssh regex as it's already present in the manager :)

@Tsiorifamonjena Tsiorifamonjena force-pushed the feat/pci-instances-creation-list-ssh-key branch 3 times, most recently from 15529d6 to dad0b04 Compare November 13, 2025 10:59
@Tsiorifamonjena
Copy link
Contributor Author

@Tsiorifamonjena I was thinking that ssh key should not contain any blank space but I think it's wrong, it can contain between each part. To trim it is a good practise, but maybe check the right ssh regex as it's already present in the manager :)

You were right @lolottetheclash :)

here is the ssh key format <type> <base64-encoded-key> and base64-encoded-key should not contain any blank space. I searched the entire manager but there is no regex. Validation is done on the backend side for existing form.

I improve the regex and I let you see

Copy link
Contributor

@lolottetheclash lolottetheclash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I click on "create a new ssh key" for the first time, I have the impression that page reloads, do you have the same behavior?

@Tsiorifamonjena Tsiorifamonjena force-pushed the feat/pci-instances-creation-list-ssh-key branch from dad0b04 to ddbd7bd Compare November 13, 2025 15:05
@Tsiorifamonjena
Copy link
Contributor Author

When I click on "create a new ssh key" for the first time, I have the impression that page reloads, do you have the same behavior?

@lolottetheclash the translation was probably loaded in my local, that's why I didn't have the same behavior.
The problem was from common translation not yet load on mounting the AddSshKey component for the first time (after click create a new ssh key) then react-i18next fetch and there is a fallback.

I fix it by adding the namespace in the init I let you see

@Tsiorifamonjena Tsiorifamonjena force-pushed the feat/pci-instances-creation-list-ssh-key branch 4 times, most recently from dc5622d to 63ea005 Compare November 14, 2025 16:48
@Tsiorifamonjena Tsiorifamonjena marked this pull request as draft November 14, 2025 20:46
@Tsiorifamonjena Tsiorifamonjena force-pushed the feat/pci-instances-creation-list-ssh-key branch 2 times, most recently from 80104bb to 95ae64d Compare November 14, 2025 20:57
@Tsiorifamonjena Tsiorifamonjena marked this pull request as ready for review November 17, 2025 08:31
ref: #TAPC-4623, #TAPC-4626

Signed-off-by: tsiorifamonjena <[email protected]>
Co-authored-by: CDS Translator Agent <[email protected]>
@Tsiorifamonjena Tsiorifamonjena force-pushed the feat/pci-instances-creation-list-ssh-key branch from 95ae64d to c72cd6a Compare November 17, 2025 10:23
@Tsiorifamonjena Tsiorifamonjena merged commit ae9da5d into feat/add-instance-creation-page-TAPC-4445 Nov 17, 2025
11 of 13 checks passed
@Tsiorifamonjena Tsiorifamonjena deleted the feat/pci-instances-creation-list-ssh-key branch November 17, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants