-
Notifications
You must be signed in to change notification settings - Fork 112
feat(pci-instances): add list of ssh keys #20291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pci-instances): add list of ssh keys #20291
Conversation
0c42d6e to
337021d
Compare
337021d to
f1d0fbd
Compare
47f7b1a to
5bd8799
Compare
5bd8799 to
dbc4191
Compare
dbc4191 to
27376fc
Compare
lolottetheclash
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should improve the SSH key regex: it should not valid the fact that it can contain some blank spaces into the ssh key, and also you should trim it before testing it
packages/manager/apps/pci-instances/src/components/banner/Banner.component.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-instances/src/components/banner/Banner.component.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-instances/src/pages/instances/create/components/SshKey.component.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-instances/src/pages/instances/create/components/SshKey.component.tsx
Outdated
Show resolved
Hide resolved
| useEffect(() => { | ||
| if (!isLoading) setSshKeyItems(sshKeys); | ||
| }, [isLoading, sshKeys]); | ||
|
|
||
| useEffect(() => { | ||
| if (!isLoading && sshKeys.length === 0) setOpenSshKeyForm(true); | ||
| }, [isLoading, sshKeys]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can merge those two use effect (same dependencies)
27376fc to
b4ff286
Compare
|
@Tsiorifamonjena I was thinking that ssh key should not contain any blank space but I think it's wrong, it can contain between each part. To trim it is a good practise, but maybe check the right ssh regex as it's already present in the manager :) |
15529d6 to
dad0b04
Compare
You were right @lolottetheclash :) here is the ssh key format I improve the regex and I let you see |
lolottetheclash
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I click on "create a new ssh key" for the first time, I have the impression that page reloads, do you have the same behavior?
dad0b04 to
ddbd7bd
Compare
@lolottetheclash the translation was probably loaded in my local, that's why I didn't have the same behavior. I fix it by adding the namespace in the |
dc5622d to
63ea005
Compare
80104bb to
95ae64d
Compare
ref: #TAPC-4623, #TAPC-4626 Signed-off-by: tsiorifamonjena <[email protected]> Co-authored-by: CDS Translator Agent <[email protected]>
95ae64d to
c72cd6a
Compare
ae9da5d
into
feat/add-instance-creation-page-TAPC-4445
Description
Ticket Reference: #TAPC-4623, #TAPC-4626
Additional Information