Skip to content

Conversation

@s0ph0s-dog
Copy link
Contributor

This PR adds a proper macOS About window to this application, which:

  • is a window;
  • shows the app icon, version, copyright info, and release channel;
  • closes when you press escape;
  • and offers a real button to copy the version string to the pasteboard.

Right now, it is properly translated for English. I have no idea how the Telegram translation framework works, and I would greatly appreciate guidance on how to implement it so that people who read other languages can benefit from this change as well.

Is this PR acceptable? Have I matched the code style? I would love to see this implemented, so if there's anything you don't like about how I've done it, please let me know so I can improve it :3

@CLAassistant
Copy link

CLAassistant commented Apr 13, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@s0ph0s-dog
Copy link
Contributor Author

s0ph0s-dog commented Apr 24, 2019

@overtake I’d love to hear what you think about this PR. If it’s a flat-out rejection, that’s totally fine—please let me know so I can make any changes you’d like, or just move on.

@overtake overtake force-pushed the master branch 3 times, most recently from 9aa8690 to 579cebb Compare September 22, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants