Skip to content

Changed caching #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dylanratcliffe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Changed caching #498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 25 additions & 25 deletions modules/agm-talk/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,23 +136,23 @@ resource "aws_cloudfront_distribution" "app" {
# 2. Uncomment the AFTER block below
# 3. terraform apply
# ===========================================================================
default_cache_behavior {
allowed_methods = ["GET", "HEAD", "OPTIONS"]
cached_methods = ["GET", "HEAD"]
target_origin_id = "lambda-app"
viewer_protocol_policy = "allow-all"

forwarded_values {
query_string = false
cookies {
forward = "none"
}
}

min_ttl = 1
default_ttl = 1
max_ttl = 1
}
# default_cache_behavior {
# allowed_methods = ["GET", "HEAD", "OPTIONS"]
# cached_methods = ["GET", "HEAD"]
# target_origin_id = "lambda-app"
# viewer_protocol_policy = "allow-all"

# forwarded_values {
# query_string = false
# cookies {
# forward = "none"
# }
# }

# min_ttl = 1
# default_ttl = 1
# max_ttl = 1
# }

# ===========================================================================
# AFTER: The dangerous config (cache policy + origin request policy)
Expand All @@ -167,14 +167,14 @@ resource "aws_cloudfront_distribution" "app" {
#
# To activate: uncomment this block and comment out the BEFORE block above.
# ===========================================================================
# default_cache_behavior {
# allowed_methods = ["GET", "HEAD", "OPTIONS"]
# cached_methods = ["GET", "HEAD"]
# target_origin_id = "lambda-app"
# viewer_protocol_policy = "allow-all"
# cache_policy_id = aws_cloudfront_cache_policy.static_assets.id
# origin_request_policy_id = aws_cloudfront_origin_request_policy.forward_all.id
# }
default_cache_behavior {
allowed_methods = ["GET", "HEAD", "OPTIONS"]
cached_methods = ["GET", "HEAD"]
target_origin_id = "lambda-app"
viewer_protocol_policy = "allow-all"
cache_policy_id = aws_cloudfront_cache_policy.static_assets.id
origin_request_policy_id = aws_cloudfront_origin_request_policy.forward_all.id
}

restrictions {
geo_restriction {
Expand Down