Update loom.tf #355
Open
Update loom.tf #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 env0 had composed a PR Plan for environment Terraform Example / production : Plan DetailsTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
! update in-place
-/+ destroy and then create replacement
Terraform will perform the following actions:
# module.scenarios[0].aws_ecs_service.face will be updated in-place
! resource "aws_ecs_service" "face" {
id = "arn:aws:ecs:eu-west-2:540044833068:service/example-terraform-example/facial-recognition"
name = "facial-recognition"
tags = {}
! task_definition = "arn:aws:ecs:eu-west-2:540044833068:task-definition/facial-recognition-terraform-example:9" -> (known after apply)
# (15 unchanged attributes hidden)
# (5 unchanged blocks hidden)
}
# module.scenarios[0].aws_ecs_task_definition.face must be replaced
-/+ resource "aws_ecs_task_definition" "face" {
! arn = "arn:aws:ecs:eu-west-2:540044833068:task-definition/facial-recognition-terraform-example:9" -> (known after apply)
! arn_without_revision = "arn:aws:ecs:eu-west-2:540044833068:task-definition/facial-recognition-terraform-example" -> (known after apply)
! container_definitions = jsonencode(
! [
! {
! healthCheck = {
! command = [
"CMD-SHELL",
- "wget -q --spider localhost:1234",
+ "wget -q --spider localhost:2222",
]
# (3 unchanged attributes hidden)
}
name = "facial-recognition"
! portMappings = [
! {
- hostPort = 1234
- protocol = "tcp"
# (2 unchanged attributes hidden)
},
]
- systemControls = []
# (7 unchanged attributes hidden)
},
] # forces replacement
)
! enable_fault_injection = false -> (known after apply)
! id = "facial-recognition-terraform-example" -> (known after apply)
! revision = 9 -> (known after apply)
- tags = {} -> null
! tags_all = {} -> (known after apply)
# (7 unchanged attributes hidden)
}
# module.scenarios[0].module.cloudfront.aws_cloudfront_distribution.this[0] will be updated in-place
! resource "aws_cloudfront_distribution" "this" {
id = "EX4HFUQMZ2ULI"
tags = {}
# (20 unchanged attributes hidden)
- custom_error_response {
- error_caching_min_ttl = 0 -> null
- error_code = 403 -> null
- response_code = 403 -> null
- response_page_path = "/errors/403.html" -> null
}
- custom_error_response {
- error_caching_min_ttl = 0 -> null
- error_code = 404 -> null
- response_code = 404 -> null
- response_page_path = "/errors/404.html" -> null
}
+ custom_error_response {
+ error_code = 403
+ response_code = 404
+ response_page_path = "/errors/403.html"
}
+ custom_error_response {
+ error_code = 404
+ response_code = 404
+ response_page_path = "/errors/404.html"
}
# (8 unchanged blocks hidden)
}
Plan: 1 to add, 2 to change, 1 to destroy.
|
|
Open in Overmind ↗
🔴 Change SignalsRoutine 🔴 🔥 RisksHealth check changed to wrong port will mark all tasks unhealthy and cause outage When this revision deploys, new tasks will fail their container health checks and be replaced repeatedly. As the service rolls to the new revision, healthy tasks will be drained and replaced by unhealthy ones, resulting in zero healthy tasks and a service outage. 403 errors will be returned as 404 and error responses will be cached due to removal of zero TTL Additionally, error_caching_min_ttl is being removed (set to null) for the 403 and 404 entries, replacing the explicit 0s with the provider’s default error caching. Error responses that were previously not cached will now be cached for a non-zero period, leading to stale 404/403 pages being served after transient issues or permission fixes. The current state shows ErrorCachingMinTTL: 0 with 403->403 and 404->404, so this change will directly modify both status code semantics and error caching behavior at the edge. 🟣 Expected Changes+/- ecs-task-definition › facial-recognition-terraform-example--- current
+++ proposed
@@ -2,17 +2,23 @@
id: github.com/overmindtech/terraform-example.ecs-task-definition.module.scenarios[0].aws_ecs_task_definition.face
attributes:
- arn: arn:aws:ecs:eu-west-2:540044833068:task-definition/facial-recognition-terraform-example:9
- arn_without_revision: arn:aws:ecs:eu-west-2:540044833068:task-definition/facial-recognition-terraform-example
- container_definitions: '[{"cpu":1024,"environment":[{"name":"DATABASE_URL","value":"tf-20251117235257281600000001.cnx7xf6hwmba.eu-west-2.rds.amazonaws.com"}],"essential":true,"healthCheck":{"command":["CMD-SHELL","wget -q --spider localhost:1234"],"interval":30,"retries":3,"timeout":5},"image":"harshmanvar/face-detection-tensorjs:slim-amd","memory":2048,"mountPoints":[],"name":"facial-recognition","portMappings":[{"appProtocol":"http","containerPort":1234,"hostPort":1234,"protocol":"tcp"}],"systemControls":[],"volumesFrom":[]}]'
+ arn: (known after apply)
+ arn_without_revision: (known after apply)
+ container_definitions: '[{"cpu":1024,"environment":[{"name":"DATABASE_URL","value":"tf-20251117235257281600000001.cnx7xf6hwmba.eu-west-2.rds.amazonaws.com"}],"essential":true,"healthCheck":{"command":["CMD-SHELL","wget -q --spider localhost:2222"],"interval":30,"retries":3,"timeout":5},"image":"harshmanvar/face-detection-tensorjs:slim-amd","memory":2048,"mountPoints":[],"name":"facial-recognition","portMappings":[{"appProtocol":"http","containerPort":1234}],"volumesFrom":[]}]'
cpu: "1024"
- enable_fault_injection: false
+ enable_fault_injection: (known after apply)
+ execution_role_arn: null
family: facial-recognition-terraform-example
- id: facial-recognition-terraform-example
+ id: (known after apply)
+ ipc_mode: null
memory: "2048"
network_mode: awsvpc
+ pid_mode: null
requires_compatibilities:
- FARGATE
- revision: 9
+ revision: (known after apply)
skip_destroy: false
+ tags: null
+ tags_all: (known after apply)
+ task_role_arn: null
terraform_address: module.scenarios[0].aws_ecs_task_definition.face
terraform_name: module.scenarios[0].aws_ecs_task_definition.face
~ cloudfront-distribution › EX4HFUQMZ2ULI--- current
+++ proposed
@@ -6,9 +6,9 @@
comment: My awesome CloudFront
custom_error_response:
- - error_caching_min_ttl: 0
+ - error_caching_min_ttl: null
error_code: 403
- response_code: 403
+ response_code: 404
response_page_path: /errors/403.html
- - error_caching_min_ttl: 0
+ - error_caching_min_ttl: null
error_code: 404
response_code: 404
🟠 Unmapped Changes~ aws_ecs_service › module.scenarios[0].aws_ecs_service.face--- current
+++ proposed
@@ -38,5 +38,5 @@
propagate_tags: NONE
scheduling_strategy: REPLICA
- task_definition: arn:aws:ecs:eu-west-2:540044833068:task-definition/facial-recognition-terraform-example:9
+ task_definition: (known after apply)
terraform_address: module.scenarios[0].aws_ecs_service.face
terraform_name: module.scenarios[0].aws_ecs_service.face
💥 Blast RadiusItems Edges |
Member
Author
|
Open in Overmind ↗🔴 Change SignalsRoutine 🔴 🔥 Risks
🟣 Expected Changes+/- ecs-task-definition › facial-recognition-terraform-example--- current
+++ proposed
@@ -2,17 +2,23 @@
id: github.com/overmindtech/terraform-example.ecs-task-definition.module.scenarios[0].aws_ecs_task_definition.face
attributes:
- arn: arn:aws:ecs:eu-west-2:540044833068:task-definition/facial-recognition-terraform-example:9
- arn_without_revision: arn:aws:ecs:eu-west-2:540044833068:task-definition/facial-recognition-terraform-example
- container_definitions: '[{"cpu":1024,"environment":[{"name":"DATABASE_URL","value":"tf-20251117235257281600000001.cnx7xf6hwmba.eu-west-2.rds.amazonaws.com"}],"essential":true,"healthCheck":{"command":["CMD-SHELL","wget -q --spider localhost:1234"],"interval":30,"retries":3,"timeout":5},"image":"harshmanvar/face-detection-tensorjs:slim-amd","memory":2048,"mountPoints":[],"name":"facial-recognition","portMappings":[{"appProtocol":"http","containerPort":1234,"hostPort":1234,"protocol":"tcp"}],"systemControls":[],"volumesFrom":[]}]'
+ arn: (known after apply)
+ arn_without_revision: (known after apply)
+ container_definitions: '[{"cpu":1024,"environment":[{"name":"DATABASE_URL","value":"tf-20251117235257281600000001.cnx7xf6hwmba.eu-west-2.rds.amazonaws.com"}],"essential":true,"healthCheck":{"command":["CMD-SHELL","wget -q --spider localhost:2222"],"interval":30,"retries":3,"timeout":5},"image":"harshmanvar/face-detection-tensorjs:slim-amd","memory":2048,"mountPoints":[],"name":"facial-recognition","portMappings":[{"appProtocol":"http","containerPort":1234}],"volumesFrom":[]}]'
cpu: "1024"
- enable_fault_injection: false
+ enable_fault_injection: (known after apply)
+ execution_role_arn: null
family: facial-recognition-terraform-example
- id: facial-recognition-terraform-example
+ id: (known after apply)
+ ipc_mode: null
memory: "2048"
network_mode: awsvpc
+ pid_mode: null
requires_compatibilities:
- FARGATE
- revision: 9
+ revision: (known after apply)
skip_destroy: false
+ tags: null
+ tags_all: (known after apply)
+ task_role_arn: null
terraform_address: module.scenarios[0].aws_ecs_task_definition.face
terraform_name: module.scenarios[0].aws_ecs_task_definition.face
~ cloudfront-distribution › EX4HFUQMZ2ULI--- current
+++ proposed
@@ -6,9 +6,9 @@
comment: My awesome CloudFront
custom_error_response:
- - error_caching_min_ttl: 0
+ - error_caching_min_ttl: null
error_code: 403
- response_code: 403
+ response_code: 404
response_page_path: /errors/403.html
- - error_caching_min_ttl: 0
+ - error_caching_min_ttl: null
error_code: 404
response_code: 404
🟠 Unmapped Changes~ aws_ecs_service › module.scenarios[0].aws_ecs_service.face--- current
+++ proposed
@@ -38,5 +38,5 @@
propagate_tags: NONE
scheduling_strategy: REPLICA
- task_definition: arn:aws:ecs:eu-west-2:540044833068:task-definition/facial-recognition-terraform-example:9
+ task_definition: (known after apply)
terraform_address: module.scenarios[0].aws_ecs_service.face
terraform_name: module.scenarios[0].aws_ecs_service.face
💥 Blast RadiusItems Edges |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.