Skip to content

Remove signing for now #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,6 @@ jobs:
with:
fetch-depth: 0

# - name: Install Gon from fork
# run: |
# curl -o gon -L https://github.com/dylanratcliffe/gon/releases/download/apple-silicon-fix/gon
# chmod +x gon

- name: Go Init
uses: ./.github/actions/go_init
with:
Expand All @@ -35,10 +30,9 @@ jobs:
uses: goreleaser/goreleaser-action@v5
with:
version: latest
args: release --clean --skip sign
args: release --clean
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
AC_PASSWORD: ${{ secrets.APPLE_AC_PASSWORD }}

bump-formula:
runs-on: ubuntu-latest
Expand Down
37 changes: 20 additions & 17 deletions .goreleaser.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,23 +21,26 @@ builds:
goos:
- darwin

signs:
- id: amd64
signature: "overmind-cli-amd64.dmg"
ids:
- overmind-macos # here we filter the macos only build id
cmd: ./gon
args:
- gon-amd64.json
artifacts: all
- id: arm64
signature: "overmind-cli-arm64.dmg"
ids:
- overmind-macos # here we filter the macos only build id
cmd: ./gon
args:
- gon-arm64.json
artifacts: all
# For now we are going to disable signing MacOS packages. This works on Dylan's
# person laptop, but we haven't worked out a way to get this set up in a github
# action yet.
# signs:
# - id: amd64
# signature: "overmind-cli-amd64.dmg"
# ids:
# - overmind-macos # here we filter the macos only build id
# cmd: ./gon
# args:
# - gon-amd64.json
# artifacts: all
# - id: arm64
# signature: "overmind-cli-arm64.dmg"
# ids:
# - overmind-macos # here we filter the macos only build id
# cmd: ./gon
# args:
# - gon-arm64.json
# artifacts: all

archives:
- format: tar.gz
Expand Down