Skip to content

[WIP] Remove obsolete option #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Remove obsolete option #763

wants to merge 1 commit into from

Conversation

murtukov
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? yes
Tests pass? yes
Documented? no

Remove obsolete config option resolver_maps

@murtukov
Remove obsolete option
4c5f174 
Remove obsolete config option 'resolver_maps'
@murtukov murtukov requested a review from mcg-web October 13, 2020 05:30
@murtukov murtukov mentioned this pull request Oct 13, 2020
Closed
@murtukov murtukov changed the title Remove obsolete option [WIP] Remove obsolete option Oct 13, 2020
@murtukov murtukov removed the request for review from mcg-web October 13, 2020 05:43
@murtukov
Copy link
Contributor Author

@mcg-web Simply removing the option from configs is not enough, there are some errors appearing in OverblogGraphQLExtension::setSchemaArguments(), which I could not resolve. Can you take a look at it? Feel free to close this PR if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@murtukov