WIP: make size of external memory managed by callers #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tracking This change adds a complementary function to deprecatedReportExtraMemory that allows reporting when external memory is freed. This makes the deprecated API actually useful for cases like NAPI's napi_adjust_external_memory which needs to track both allocations and deallocations. Changes: - Add deprecatedReportExtraMemoryFreed() and deprecatedReportExtraMemoryFreedSlowCase() - Remove automatic reset of m_deprecatedExtraMemorySize during full GC collections - The counter is now fully managed by the caller through allocate/free calls This is backwards compatible - existing code that only reports allocations continues to work unchanged. 🤖 Generated with Claude Code Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.