🔥 refactor: Merge --plain and --msword option into new one --style [msword,plain]

[emmanuel-quevillon-outscale]

It solve also option precedence when using both options on the command line as shown below:

➜  oks-cli cluster list --plain --msword
|          NAME         |    CREATED    |    UPDATED    |   STATUS   | DEFAULT |
| clusterapi-management |  11 days ago  |  11 days ago  |   ready    |         |
|   anotherclusterapi   |   2 days ago  |   2 days ago  |   ready    |         |

~/work/src/oks-stuffs/cluster-api via 🐍 v3.13.5 (.venv-oks-cli)
➜  oks-cli cluster list --msword --plain
|          NAME         |    CREATED    |    UPDATED    |   STATUS   | DEFAULT |
| clusterapi-management |  11 days ago  |  11 days ago  |   ready    |         |
|   anotherclusterapi   |   2 days ago  |   2 days ago  |   ready    |         |

As shown and based on the conditions in the code, it's always --msword option that wins. Introducing --style option, this behaviour won't happen anymore.
Style --msword and --plain options are supported, but deprecated with a Warning message as shown below:

 ➜  oks-cli cluster list --plain 
DeprecationWarning: The option 'plain' is deprecated. Use --style instead
+-----------------------+---------------+---------------+------------+---------+
|          NAME         |    CREATED    |    UPDATED    |   STATUS   | DEFAULT |
+-----------------------+---------------+---------------+------------+---------+
| clusterapi-management |  11 days ago  |  11 days ago  |   ready    |         |
|   anotherclusterapi   |   3 days ago  |   3 days ago  |   ready    |         |
+-----------------------+---------------+---------------+------------+---------+

➜  oks-cli cluster list --msword      
DeprecationWarning: The option 'msword' is deprecated. Use --style instead
|          NAME         |    CREATED    |    UPDATED    |   STATUS   | DEFAULT |
| clusterapi-management |  11 days ago  |  11 days ago  |   ready    |         |
|   anotherclusterapi   |   3 days ago  |   3 days ago  |   ready    |         |

➜  oks-cli cluster list --style plain   
         NAME                   CREATED              UPDATED             STATUS          DEFAULT        
clusterapi-management         11 days ago          11 days ago           ready                          
  anotherclusterapi            3 days ago           3 days ago           ready                    

➜  oks-cli cluster list --style msword
|          NAME         |    CREATED    |    UPDATED    |   STATUS   | DEFAULT |
| clusterapi-management |  11 days ago  |  11 days ago  |   ready    |         |
|   anotherclusterapi   |   3 days ago  |   3 days ago  |   ready    |         |

In the case of multiple time option --style, the last one is considered

➜  oks-cli cluster list --style msword --style plain --style msword
|          NAME         |    CREATED    |    UPDATED    |   STATUS   | DEFAULT |
| clusterapi-management |  11 days ago  |  11 days ago  |   ready    |         |
|   anotherclusterapi   |   3 days ago  |   3 days ago  |   ready    |         |

[horkko]

Any chance someone can review it?

[outscale-ykr]

hi @horkko we cannot merge this as a minor version because it changes interaction with flags, and could break existing automation and scripts that rely on oks-cli

[horkko]

Hi @outscale-ykr
It's me, Emmanuel ;) I've used my public account to add the comment.
The PR supports both the new and old options if I remember correctly. It only prints a deprecation warning when old option is used.