Removed custom AWS Batch service role from the metaflow-computation #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubmodule. Addresses issue outerbounds#101
|
Any comments on this PR? |
josephsirak
requested changes
Jan 15, 2025
There was a problem hiding this comment.
Instead of getting rid off the existing role and policy definition can you please use the count = var. custom_batch_service_role_arn != null ? 0 : 1 to conditionally create them and then use moved blocks to move old definitions that don't have count to new definitions that do. Finally, you can use a local value that is set to var. custom_batch_service_role_arn != null ? var.custom_batch_service_role_arn : <existing-role-arn>.
This approach will allow for setting a custom role arn without forcing everyone to set it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed custom AWS Batch service role from the metaflow-computation submodule.
Addresses issue #101