Skip to content

light/dark mode tooltips #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

light/dark mode tooltips #133

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a3fc7f
Update chart.ts
jmonster Jan 20, 2025
8da1956
update tooltip text color
jmonster Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/components/charts/chart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,8 @@ export default class AstraChart extends ClassifiedElement {
const isXAxisDate = !!(this.columns[0] && formattedSource.some((item) => isDate(item[this.columns[0]] as string)))
const isYAxisDate = !!(this.columns[1] && formattedSource.some((item) => isDate(item[this.columns[1]] as string)))

const tooltipBgColor = this.theme === 'light' ? 'white' : 'black'

if (this.type === 'radar') {
return {
radar: {
Expand All @@ -385,6 +387,10 @@ export default class AstraChart extends ClassifiedElement {
tooltip: {
trigger: 'item',
borderColor: gridLineColors, // fix issue where 'item' tooltips were a different color than the rest (maybe it matched the series color)
backgroundColor: tooltipBgColor,
textStyle: {
color: this.theme === 'dark' ? '#FFFFFF' : '#000000',
},
},
}
}
Expand All @@ -398,6 +404,10 @@ export default class AstraChart extends ClassifiedElement {
tooltip: {
trigger: this.type === 'scatter' ? 'item' : 'axis',
borderColor: gridLineColors, // fix issue where 'item' tooltips were a different color than the rest (maybe it matched the series color)
backgroundColor: tooltipBgColor,
textStyle: {
color: this.theme === 'dark' ? '#FFFFFF' : '#000000',
},
},
legend: {
show: !this.omitLegend && isTall,
Expand Down Expand Up @@ -583,6 +593,7 @@ export default class AstraChart extends ClassifiedElement {

private addSeries(_options: EChartsOption) {
const options = { ..._options }
const tooltipBgColor = this.theme !== 'dark' ? 'black' : 'dark'

switch (this.type) {
case 'column':
Expand Down Expand Up @@ -679,6 +690,10 @@ export default class AstraChart extends ClassifiedElement {
tooltip: {
trigger: 'item',
borderColor: this.theme === 'dark' ? '#FFFFFF08' : '#00000010', // fix issue where 'item' tooltips were a different color than the rest (maybe it matched the series color)
backgroundColor: tooltipBgColor,
textStyle: {
color: this.theme === 'dark' ? '#FFFFFF' : '#000000',
},
},
})

Expand Down