Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter the NOT supported MIMEs in Assets list. Albums or favorite #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anderestebanez
Copy link

@anderestebanez anderestebanez commented Sep 18, 2024

The HASS log as to many record when there are many not suported MIME photos in a album or as favorite. This is because the photos are not filtered in the moment of creating the album asset list.
As solution I propose to move the filter to 'list_favorite_images' and 'list_album_images' using 'originalMimeType' variable.

Test with an album tht has 100% of heic photos.

Before the change: every second
image

After the change: every 5 minutes
image

@9zigen
Copy link

9zigen commented Jan 11, 2025

Not really. this fix allows you to initially load a supported image format, though not in original quality this is preview and it is of good quality and suitable for use in photo frames, etc.

@anderestebanez
Copy link
Author

anderestebanez commented Jan 11, 2025

As I understood we are proposing two options:

  • 9zigen: Using the thumbnail. With this solution you reduce the quality but you can show all imege formats.
  • Me: it's not a solution, it only reduces the number of errors in the log.
    Another solution could be to use the 'pillow_heif' library to transform the heic to jpg. If you think that it is a solution I can try to make a proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants