Add option to redact data from exceptions #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simoleone Hey, thanks for pinging, I think this predated my active involvement so wasn't quite on my radar. I'd be happy to work with you on it if you'd like to rebase it. I'll add some comments and questions now to keep this moving. |
geemus
requested changes
Oct 15, 2025
| @config.fetch(:validate_header, true) | ||
| end | ||
|
|
||
| def redact_response_errors |
There was a problem hiding this comment.
From looking at validators/etc, I think maybe this would impact any validations (not just response ones). Could you verify? Especially if that is true, it probably would make sense to just have this be named redact_errors.
There was a problem hiding this comment.
Also, it would be great to add one or more tests to verify the behavior for things other than response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
It is useful to be able to redact data values in production environments. This prevents PII and other sensitive data from reaching logging and error reporting systems. It's especially useful for response validation error handling, when the server will typically respond with an HTTP 500 and a generic error message, and an exception reporting tool will receive the raw exception.
This PR adds an option to do this, and modifies all of the exception classes which contain a value to support redacting the value. I also refactored the
Optionsclass to pass it around throughout the validation code instead of destructuring it into the individual options it contains. This is a bit more flexible if more options are needed in the future.