-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Sorting by GitHubUpdatedAt field #23
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @alexdor, I am getting "This branch has no conflicts with the base branch". Can you verify if you are able to merge? |
alexdor
requested changes
Oct 8, 2019
Yeah looks fine, just one comment |
alexdor
requested changes
Oct 9, 2019
migrations/20190313142702_add_github_updated_at_to_issues.up.fizz
Outdated
Show resolved
Hide resolved
Hi @alexdor, any more changes required in the PR? |
No, it should be ok but I need to test it locally and so far I didn’t had time to do it, sorry for the delay I’ll try to do it tomorrow
Best,
Alex
…On 13 Oct 2019, 05:57 +0200, Himank Pathak ***@***.***>, wrote:
Hi @alexdor, any more changes required in the PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
This was referenced Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Added GitHubUpdatedAt field which is fetched from GitHub's GraphQL API "updatedAt". It is stored in the database at column GitHubUpdatedAt.
Benefits
Now issues will be sorted using GitHubUpdatedAt field by default.
Applicable Issues
Closes #5
Closes #7
Closes #12