Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting by GitHubUpdatedAt field #17

Closed
wants to merge 24 commits into from

Conversation

himankpathak
Copy link
Contributor

@himankpathak himankpathak commented Mar 21, 2019

Description of the Change

Added GitHubUpdatedAt field which is fetched from GitHub's GraphQL API "updatedAt". It is stored in database at column GitHubUpdatedAt.

Benefits

Now issues can be sorted using GitHubUpdatedAt field.

Applicable Issues

Closes #5
Closes #7
Closes #12

@himankpathak
Copy link
Contributor Author

@alexdor should a new issue be opened in the frontend to sort using GitHubUpdatedAt field?

Copy link
Member

@alexdor alexdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good : ) Could you also set the GithubUpdateAt field as the default sorting for queries?

models/issue.go Outdated Show resolved Hide resolved
@alexdor
Copy link
Member

alexdor commented Mar 21, 2019

@alexdor should a new issue be opened in the frontend to sort using GitHubUpdatedAt field?

Yes, once this is merged we should do that : )

@himankpathak himankpathak requested a review from alexdor October 6, 2019 16:57
@alexdor
Copy link
Member

alexdor commented Oct 6, 2019

@himankpathak this still has conflicts, could you resolve the conflicts?

@himankpathak
Copy link
Contributor Author

I think I resolved all the conflicts with git rebase. The PR says "This branch has no conflicts with the base branch".
Am I missing something?

@alexdor
Copy link
Member

alexdor commented Oct 6, 2019

I'm getting this error so I don't think they where solved, you can try creating a new fork and cherry-picking your commits to that one
Screenshot 2019-10-06 at 22 57 20

@himankpathak
Copy link
Contributor Author

This is weird, on my side I don't know why it's not showing the conflicts.

Screenshot from 2019-10-07 09-39-23

Should I close this PR and make a copy of this branch from commit cd0f7ef and add commit d6f1492?

@alexdor
Copy link
Member

alexdor commented Oct 8, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish up work started at #7 Fix issue sorting
3 participants