-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sorting by GitHubUpdatedAt field #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good : ) Could you also set the GithubUpdateAt field as the default sorting for queries?
buffalo plugin package updated due to a break
@himankpathak this still has conflicts, could you resolve the conflicts? |
I think I resolved all the conflicts with git rebase. The PR says "This branch has no conflicts with the base branch". |
Yeah, try creating a new pr, maybe that will solve the issue. Before you copy the branch, try just closing this pr and opening a new one, maybe it’s a GitHub issue that it shows conflicts
Best,
Alex
…On 7 Oct 2019, 06:16 +0200, Himank Pathak ***@***.***>, wrote:
This is weird, on my side I don't know why it's not showing the conflicts.
Should I close this PR and make a copy of this branch from commit cd0f7ef and add commit d6f1492?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Description of the Change
Added GitHubUpdatedAt field which is fetched from GitHub's GraphQL API "updatedAt". It is stored in database at column GitHubUpdatedAt.
Benefits
Now issues can be sorted using GitHubUpdatedAt field.
Applicable Issues
Closes #5
Closes #7
Closes #12