Repository navigation
feat: add secret scanning policy - #897
Merged
jeffmendoza merged 2 commits intoNov 10, 2026
Merged
Conversation
|
This pull request has been marked stale because it has been open for 10 days with no activity |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
An unavailable GitHub status incorrectly passes the secret-scanning check, allowing compliance to be reported and existing violation issues to be closed without verifying that scanning is enabled.
1 open issue
What changed in this PR
Adds a Secret Scanning policy to Allstar’s policy framework, addressing #363’s request to monitor and enable GitHub secret scanning across repositories.
Changes:
- Adds configurable checks that distinguish disabled scanning from unavailable API status.
- Implements a fix action to enable secret scanning and registers the policy.
- Adds configuration-precedence and policy tests, plus setup and permission documentation.
| File | Description |
|---|---|
| README.md | Documents policy configuration, status handling, and required permissions. |
| pkg/policies/secretscanning/secretscanning.go | Implements configuration, status checks, notifications, and the fix action. |
| pkg/policies/secretscanning/secretscanning_test.go | Tests configuration precedence, status outcomes, and enablement requests. |
| pkg/policies/policies.go | Registers Secret Scanning with the available policies. |
Review effort: Balanced
Signed-off-by: bilaldeveloper4312 <bilaldeveloper4312@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Jeff Mendoza <jlm@jlm.name>
jeffmendoza
force-pushed
the
feat/secret-scanning-policy
branch
from
November 10, 2026 03:02
dc25763 to
fc7cad3
Compare
jeffmendoza
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Validation
go test ./...golangci-lint runFixes #363
AI-assisted contribution: prepared with AI assistance; validation results are listed above.