added the requirments for issue 293 Sprint5 #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrlmanoharreddy
requested changes
Nov 28, 2024
Could you please help me how to implement it correctly? I have tried to revise in different ways multiple times, but I still don't know what's wrong with my code. Could you please also specify which implementation was wrong in seven-segment display? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the key changes:
Implemented the functionality to control the seven-segment display: It should support showing numbers and characters.
Component defined in YAML file with:
name
bus
device
(I put these changes into under pi4micronaunt-utils/resource/application.yml since Reddy suggested to implement this instead of application.yml under pi4micronaunt)
These two areas met the requirements:
The schematic diagram accurately depicts the wiring for the seven-segment display.
Controller Implementation in the Components folder