-
Notifications
You must be signed in to change notification settings - Fork 347
docs: Add python-ort reference in documentation #9930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b337803
to
4cd9b1a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9930 +/- ##
============================================
- Coverage 68.46% 68.43% -0.03%
Complexity 1309 1309
============================================
Files 250 250
Lines 8881 8881
Branches 924 924
============================================
- Hits 6080 6078 -2
- Misses 2409 2412 +3
+ Partials 392 391 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
website/docs/related-tools.md
Outdated
|
||
## Python-Ort | ||
|
||
[Python-Ort](https://github.com/heliocastro/python-ort) is a pydantic based library to serialize OSS Review Toolkit generated reports using the default models. Instructions to install are available on [Python Ort Test PyPI Registry](https://test.pypi.org/project/python-ort/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- "pydantic-based"
- Should it be "de*serialize" instead?
- Maybe better "reports generated by ORT"?
- "available on the"
- Missing dot at the end of the last sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Good to go ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that @mnonnenmacher should review this primarily as it was his suggestion to add it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heliocastro Can you please squash the two commits?
Also, shouldn't it be just "Python-Ort PyPI Registry" (without "Test")?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mnonnenmacher, can you please have another look at the updated PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mnonnenmacher Is Test Pypi because is not ready to move to main registry yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heliocastro Can you please squash the two commits and get rid of the merge commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping @heliocastro, please see the comment above, which is still valid.
Signed-off-by: Helio Chissini de Castro <[email protected]>
6b17f8a
to
f3f26c9
Compare
Signed-off-by: Helio Chissini de Castro <[email protected]>
f3f26c9
to
264d226
Compare
No description provided.