Pub project type fixes #9831
Merged
Pub project type fixes #9831
+9
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Schuberth <[email protected]>
This should not be an `IOException`. Also quote the package name for readability. Signed-off-by: Sebastian Schuberth <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9831 +/- ##
=========================================
Coverage 68.11% 68.11%
+ Complexity 1289 1287 -2
=========================================
Files 249 249
Lines 8837 8837
Branches 918 918
=========================================
Hits 6019 6019
Misses 2432 2432
Partials 386 386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fviernau
requested changes
Jan 24, 2025
| @@ -72,6 +72,9 @@ internal data class PackageInfo( | |||
| ) | |||
| } | |||
|
|
|||
| internal val PackageInfo.isProject: Boolean | |||
There was a problem hiding this comment.
I believe this should be placed into pub.kt so that the Lockfile.kt reflects solely the 3rd party stuff.
Do not hard-code "Pub" as the identifier type, as it might be a (reference to a) project instead if a package. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
pub-project-type-fixes
branch
from
99cafba to
fdf9a5c
Compare
fviernau
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.