Black Duck: Support origin-id queries using the "long_tail" namespace #9827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `externalIds` for the `long_tail` namespace are simply repository URLs using e.g. the `git` protocol. The forge `Forge.LONG_TAIL` defines the `/` as the separator. When the `integration-bdio` library creates the query string, it accidentally replaces the double slash with a single one, e.g. `git:/` instead of `git://`. As result, any request returns an empty result. Work around that by simply using the `:` as separator, because no double colon should occur in any repository URL. So, when splitting and re-joining the string using `:` as separator, that issue does not happen anymore. Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
black-duck-support-long-tail-namespace
branch
from
d5e92c8 to
c607821
Compare
sschuberth
approved these changes
Jan 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9827 +/- ##
=========================================
Coverage 68.08% 68.08%
Complexity 1286 1286
=========================================
Files 249 249
Lines 8829 8829
Branches 918 918
=========================================
Hits 6011 6011
Misses 2432 2432
Partials 386 386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
externalIdsfor thelong_tailnamespace are simply repository URLs using e.g. thegitprotocol. The forgeForge.LONG_TAILdefines the/as the separator. When theintegration-bdiolibrary creates the query string, it accidentally replaces the double slash with a single one, e.g.git:/instead ofgit://. As result, any request returns an empty result.Work around that by simply using the
:as separator, because no double colon should occur in any repository URL. So, when splitting and re-joining the string using:as separator, that issue does not happen anymore.Part of: #8739.