Black Duck: Support origin-id queries using the "conan" namespace #9826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sschuberth
requested changes
Jan 24, 2025
| @@ -1,4 +1,46 @@ | |||
| { | |||
| "componentsViewsForExternalId": { | |||
There was a problem hiding this comment.
Commit message: "lacks an entry" (as you refer to plural "forges")
| @@ -58,3 +58,8 @@ internal data class BlackDuckOriginId( | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| // A replacement for `Forge.getKnownForges()`, because the latter does not contain entries for all forges. | |||
| private val KNOWN_FORGES = Forge.getKnownForges() + listOf( | |||
There was a problem hiding this comment.
Alternatively:
private val KNOWN_FORGES = Forge.getKnownForges() + Forge(":", "conan").let { it.name to it }
There was a problem hiding this comment.
I'll need to add another forge to that list (in a following PR). So, I'd prefer to keep this a list for easy extension.
fviernau
force-pushed
the
black-duck-conan-namespace-workaround
branch
from
210e6c4 to
a9500e5
Compare
This is a fix-up for ae2ae6e. Signed-off-by: Frank Viernau <[email protected]>
This is fix-up for ae2ae6e. Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
black-duck-conan-namespace-workaround
branch
from
a9500e5 to
8f1cf23
Compare
The known forges, `Forge.getKnowForges()`, defined in `bdio-integration` lack an entry for the "conan" forge. Fix this with a work around, see also [1]. [1]: blackducksoftware/integration-bdio#40 Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
black-duck-conan-namespace-workaround
branch
from
8f1cf23 to
3cfb144
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9826 +/- ##
=========================================
Coverage 68.08% 68.08%
Complexity 1286 1286
=========================================
Files 249 249
Lines 8829 8829
Branches 918 918
=========================================
Hits 6011 6011
Misses 2432 2432
Partials 386 386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sschuberth
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Part of #8739.