Maven support disk cache fixes #9824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not completely true that no version-specific features of the CLI tools are used, e.g. the `info` sub-command needs to support the `--json` option. As the comments were not using the required passive voice anyway, simply remove them. Signed-off-by: Sebastian Schuberth <[email protected]>
This just repeats the obvious implementation of `getVersionRequirement()`. As the comment was not using the required passive voice anyway, simply remove it. Signed-off-by: Sebastian Schuberth <[email protected]>
Signed-off-by: Sebastian Schuberth <[email protected]>
Originally, these functions did not really add much value over calling the code at the begin / end of `resolveDependencies()` for the respective manager. Add some value to these functions by changing when they are called: Call `beforeResolution()` before `resolveDependencies()` is called for any enabled manager, and `afterResolution()` after resolution has finished for all enabled managers. This allows to use these functions for cases where clean-ups, like the deletion of a `node_modules` directory, have to happen after another manager (like Gradle) was run, to be able to analyze complex React-Native applications with inter-dependencies between managers. Note that this requires changes to code paths that do not make use of `analyzeInParallel()`, like `resolveSingleProject()` used in tests. Signed-off-by: Sebastian Schuberth <[email protected]>
Signed-off-by: Sebastian Schuberth <[email protected]>
The `remoteArtifactCache` has never been properly closed before (until process termination). Fix that to allow the same process (e.g. in a server context) to use the cache multiple times in a row. This requires each `MavenSupport` instance to have its own instance of the disk cache. Fixes #7978. Signed-off-by: Sebastian Schuberth <[email protected]>
As `DiskLruCache` does not support concurrent edits by default [1] and making it so is hard [2], use isolated disk cache directories for Gradle and Maven to allow them to safely run in parallel. [1]: https://github.com/JakeWharton/DiskLruCache?tab=readme-ov-file#disk-lru-cache [2]: JakeWharton/DiskLruCache#19 Signed-off-by: Sebastian Schuberth <[email protected]>
Signed-off-by: Sebastian Schuberth <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9824 +/- ##
=========================================
Coverage 68.07% 68.08%
- Complexity 1285 1286 +1
=========================================
Files 249 249
Lines 8828 8829 +1
Branches 918 918
=========================================
+ Hits 6010 6011 +1
Misses 2432 2432
Partials 386 386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fviernau
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.