fix: add cache for OrtDependency model objects to OrtModelBuilder #9818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9818 +/- ##
=========================================
Coverage 68.07% 68.07%
- Complexity 1285 1287 +2
=========================================
Files 249 249
Lines 8828 8828
Branches 918 918
=========================================
Hits 6010 6010
Misses 2432 2432
Partials 386 386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sschuberth
requested changes
Jan 23, 2025
plugins/package-managers/gradle-plugin/src/main/kotlin/OrtModelBuilder.kt
Outdated
Show resolved
Hide resolved
plugins/package-managers/gradle-plugin/src/main/kotlin/OrtModelBuilder.kt
Outdated
Show resolved
Hide resolved
plugins/package-managers/gradle-plugin/src/main/kotlin/OrtModelBuilder.kt
Outdated
Show resolved
Hide resolved
sschuberth
force-pushed
the
gradle-model-object-deduplication
branch
from
60bbc2e to
95f5e0e
Compare
sschuberth
force-pushed
the
gradle-model-object-deduplication
branch
from
95f5e0e to
8c0e700
Compare
sschuberth
approved these changes
Jan 23, 2025
Only create one 'OrtDependency' for each 'ResolvedComponentResult'. The 'ResolvedComponentResult' is immutable and therefore all 'OrtDependency' object derived from the same 'ResolvedComponentResult' have the same content. Hence, we can reuse these objects to save memory and computation time. This PR is a refined version of the fix posted in the error description of [1]. [1]: oss-review-toolkit#9763 Signed-off-by: Jendrik Johannes <[email protected]>
sschuberth
force-pushed
the
gradle-model-object-deduplication
branch
from
8c0e700 to
06baf39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only create one 'OrtDependency' for each 'ResolvedComponentResult'. The 'ResolvedComponentResult' is immutable and therefore all 'OrtDependency' object derived from the same 'ResolvedComponentResult' have the same content. Hence, we can reuse these objects to save memory and computation time.
Without this, large builds seem to run forever:
#9763
This PR is a refined version of the fix posted in the error description of #9763