Add a "Project" suffix to project types #9780
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9780 +/- ##
============================================
- Coverage 68.11% 68.10% -0.01%
+ Complexity 1289 1287 -2
============================================
Files 249 249
Lines 8837 8838 +1
Branches 918 919 +1
============================================
Hits 6019 6019
- Misses 2432 2433 +1
Partials 386 386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sschuberth
force-pushed
the
project-type-suffix
branch
12 times, most recently
from
be33216 to
b4e5868
Compare
This should not be an `IOException`. Also quote the package name for readability. Signed-off-by: Sebastian Schuberth <[email protected]>
Do not hard-code "Pub" as the identifier type, as it might be a (reference to a) project instead if a package. Signed-off-by: Sebastian Schuberth <[email protected]>
In relation to #9417, this avoids duplicate project vs. package IDs by adding a "Project" suffix to the `type` of project IDs. This change breaks existing package configurations that refer to project IDs. The fix it to simply add the "Project" suffix to the type as part of the project ID in the package configurations as well. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
project-type-suffix
branch
from
b4e5868 to
db76a6d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.