Node: Re-create the lockfiles for the project-with-lockfile test projects
#9449
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9449 +/- ##
============================================
- Coverage 67.97% 67.93% -0.04%
+ Complexity 1291 1289 -2
============================================
Files 249 249
Lines 8792 8792
Branches 913 913
============================================
- Hits 5976 5973 -3
- Misses 2431 2433 +2
- Partials 385 386 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
fviernau
force-pushed
the
test-node-recreate-some-lockfiles
branch
from
adac09b to
567e8e1
Compare
| definitionFile, | ||
| custom = mapOf("<REPLACE_LOCKFILE_NAME>" to "package-lock.json") | ||
| ) | ||
| patchActualResult(result.toYaml()) should matchExpectedResult(expectedResultFile, definitionFile) |
There was a problem hiding this comment.
Should this have gone to a separate commit? In any case, please explain in the commit message why replacing REPLACE_LOCKFILE_NAME can be omitted now.
There was a problem hiding this comment.
... and why the REPLACE_LOCKFILE_NAME replacement is kept for another place in this file in the next commit.
There was a problem hiding this comment.
... and why the
REPLACE_LOCKFILE_NAMEreplacement is kept for another place in this file in the next commit.
I explained it for this commit, but not for the next one.
There was a problem hiding this comment.
...the reason why it's kept in the next one, is because the next commit is unrelated to updating any lockfile or dependencies.
fviernau
force-pushed
the
test-node-recreate-some-lockfiles
branch
from
567e8e1 to
e055a54
Compare
fviernau
force-pushed
the
test-node-recreate-some-lockfiles
branch
from
e055a54 to
bdff1f9
Compare
Make the results easier to compare. The lockfiles have been created with `npm` 10.8.3, `pnpm` 9.9.0, `yarn` 1.22.19 and `yarn2` 3.2.1. Note: The replacement for `REPLACE_LOCKFILE_NAME` is no more necessary, because the issue which mentioned the lockfile name does no more happen with the updated dependencies. Signed-off-by: Frank Viernau <[email protected]>
Remove the replacement analog to 1e58026 and dfaa896. Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
test-node-recreate-some-lockfiles
branch
from
bdff1f9 to
4295eb2
Compare
|
Merge regardless of the unrelated clearlydefined test failures. |
Make the results easy to compare.
Part of #9261.