test(analyzer): Fix-up a broken assertion #8702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschuberth
requested changes
May 27, 2024
|
|
||
| serializedResult shouldBe serializedResult | ||
| serializedResult shouldBe result |
There was a problem hiding this comment.
The original test compared YAML to YAML, which results in a textual diff on changes. Maybe this behavior could be maintained by
val serializedResult = result.toYaml()
serializedResult.fromYaml<AnalyzerResult>().toYaml() shouldBe serializedResult
This also avoids one additional fromYaml step.
The left hand side and right hand side operator of `shouldBe` were accidentally made identical by [1]. [1]: 3de069b Signed-off-by: Frank Viernau <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8702 +/- ##
=========================================
Coverage 67.85% 67.85%
Complexity 1165 1165
=========================================
Files 244 244
Lines 7736 7736
Branches 865 865
=========================================
Hits 5249 5249
Misses 2128 2128
Partials 359 359
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sschuberth
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The left hand side and right hand side operator of
shouldBewere accidentally made identical by 1.