Percent encoding / decoding test enhancements #8693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fviernau
requested changes
May 24, 2024
| @@ -375,13 +376,21 @@ class ExtensionsTest : WordSpec({ | |||
|
|
|||
| assertSoftly { | |||
There was a problem hiding this comment.
out of scope: It would imo be nice to replace assertSoftly / forEach with reserved.forAll, maybe in a separate commit.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8693 +/- ##
=========================================
Coverage 67.88% 67.88%
Complexity 1165 1165
=========================================
Files 244 244
Lines 7732 7732
Branches 865 865
=========================================
Hits 5249 5249
Misses 2124 2124
Partials 359 359
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fviernau
previously approved these changes
May 24, 2024
Verify that Java's regular `URLDecoder` can decode string to the original. Signed-off-by: Sebastian Schuberth <[email protected]>
Update some function names in test titles while at it. Signed-off-by: Sebastian Schuberth <[email protected]>
Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
percent-encoding-decoding-test
branch
from
1f60500 to
779fbc9
Compare
fviernau
previously approved these changes
May 24, 2024
Move the stand-alone assertion to the begging of the block for visibility while at it. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
percent-encoding-decoding-test
branch
from
779fbc9 to
963a987
Compare
fviernau
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.