Docker build script fixes #8685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
... but this is the least intrusive fix
Maybe, but wouldn't it be cleaner to just remove the --build-arg lines instead?
There was a problem hiding this comment.
That's what I was trying at first as well, but it does not work as the variables are also used as part of version strings / tags like "${JAVA_VERSION}-jdk-${UBUNTU_VERSION}".
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8685 +/- ##
============================================
+ Coverage 67.53% 67.85% +0.31%
Complexity 1165 1165
============================================
Files 245 244 -1
Lines 7772 7736 -36
Branches 867 865 -2
============================================
Hits 5249 5249
+ Misses 2164 2128 -36
Partials 359 359
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sschuberth
force-pushed
the
docker-build-script
branch
from
361ff45 to
5792b47
Compare
This is a fixup for ae16d01. It somewhat takes the long way around, reading the variables from `versions.dockerfile` just to pass them in as build arguments again, but this is the least intrusive fix. Signed-off-by: Sebastian Schuberth <[email protected]>
This enables compatibility with the `--build-context` option as used by the `docker_build.sh` script. Also see [1]. [1]: https://codeberg.org/devthefuture/dockerfile-x/issues/4 Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
docker-build-script
branch
from
5792b47 to
c996a2c
Compare
heliocastro
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.