refactor(docker): Define tool versions only once #8648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8648 +/- ##
=========================================
Coverage 67.92% 67.92%
Complexity 1005 1005
=========================================
Files 244 244
Lines 7772 7772
Branches 876 876
=========================================
Hits 5279 5279
Misses 2110 2110
Partials 383 383
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sschuberth
force-pushed
the
docker-versions-include
branch
2 times, most recently
from
47f96b7 to
c60094d
Compare
This is a fixup for 14cc5f1. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
docker-versions-include
branch
from
c60094d to
f5625d4
Compare
Previously, tool versions have been defined both inside the `.versions` file and as part of default `ARG` values. Consolidate these to `ARG` values only that get used where needed. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
docker-versions-include
branch
from
f5625d4 to
16cb891
Compare
|
@oheger-bosch, @MarcelBochtler, @heliocastro can I get an approval from your side? |
heliocastro
approved these changes
May 15, 2024
I agree it's not super-nice, and I once filed this issue about it, but did not find the time so far to implement it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, tool versions have been defined both inside the
.versionsfile and as part of defaultARGvalues. Consolidate these toARGvalues only that get used where needed.