feat(scanner): Add branch name to FossID scan code #8641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-bielecki-bosch
force-pushed
the
add_branch_name_to_fossid_scan_code
branch
from
efc3d6c to
088c960
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8641 +/- ##
=========================================
Coverage 67.84% 67.84%
Complexity 1164 1164
=========================================
Files 244 244
Lines 7735 7735
Branches 864 864
=========================================
Hits 5248 5248
Misses 2128 2128
Partials 359 359
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kamil-bielecki-bosch
force-pushed
the
add_branch_name_to_fossid_scan_code
branch
3 times, most recently
from
651c2b3 to
bbf6e42
Compare
Commit messages should be written in "imperative mood" and titles should not end in a dot, so use "feat(scanner): Add a branch name to the FossID scan code" |
nnobelis
reviewed
May 17, 2024
plugins/scanners/fossid/src/main/kotlin/FossIdNamingProvider.kt
Outdated
Show resolved
Hide resolved
plugins/scanners/fossid/src/test/kotlin/FossIdNamingProviderTest.kt
Outdated
Show resolved
Hide resolved
|
Please also document the new builtin: https://github.com/oss-review-toolkit/ort/blob/main/plugins/scanners/fossid/src/main/kotlin/FossIdNamingProvider.kt#L28-L39 |
fviernau
previously requested changes
May 17, 2024
plugins/scanners/fossid/src/test/kotlin/FossIdNamingProviderTest.kt
Outdated
Show resolved
Hide resolved
kamil-bielecki-bosch
force-pushed
the
add_branch_name_to_fossid_scan_code
branch
4 times, most recently
from
82595dc to
4f493bc
Compare
kamil-bielecki-bosch
force-pushed
the
add_branch_name_to_fossid_scan_code
branch
3 times, most recently
from
35c3ced to
c2f0f80
Compare
sschuberth
previously requested changes
May 24, 2024
plugins/scanners/fossid/src/main/kotlin/FossIdNamingProvider.kt
Outdated
Show resolved
Hide resolved
plugins/scanners/fossid/src/main/kotlin/FossIdNamingProvider.kt
Outdated
Show resolved
Hide resolved
plugins/scanners/fossid/src/main/kotlin/FossIdNamingProvider.kt
Outdated
Show resolved
Hide resolved
plugins/scanners/fossid/src/test/kotlin/FossIdNamingProviderTest.kt
Outdated
Show resolved
Hide resolved
plugins/scanners/fossid/src/test/kotlin/FossIdNamingProviderTest.kt
Outdated
Show resolved
Hide resolved
kamil-bielecki-bosch
force-pushed
the
add_branch_name_to_fossid_scan_code
branch
from
c2f0f80 to
f1628a0
Compare
nnobelis
requested changes
Jun 5, 2024
plugins/scanners/fossid/src/main/kotlin/FossIdNamingProvider.kt
Outdated
Show resolved
Hide resolved
plugins/scanners/fossid/src/main/kotlin/FossIdNamingProvider.kt
Outdated
Show resolved
Hide resolved
plugins/scanners/fossid/src/main/kotlin/FossIdNamingProvider.kt
Outdated
Show resolved
Hide resolved
oheger-bosch
reviewed
Jun 5, 2024
plugins/scanners/fossid/src/main/kotlin/FossIdNamingProvider.kt
Outdated
Show resolved
Hide resolved
plugins/scanners/fossid/src/test/kotlin/FossIdNamingProviderTest.kt
Outdated
Show resolved
Hide resolved
kamil-bielecki-bosch
force-pushed
the
add_branch_name_to_fossid_scan_code
branch
from
f1628a0 to
217c683
Compare
sschuberth
changed the title
kamil-bielecki-bosch
force-pushed
the
add_branch_name_to_fossid_scan_code
branch
2 times, most recently
from
e4b35c8 to
1556a46
Compare
|
My comments have been addressed as well. @nnobelis, anything open on your side? Otherwise, I think this can be merged once the detekt issues have been resolved. |
kamil-bielecki-bosch
force-pushed
the
add_branch_name_to_fossid_scan_code
branch
from
1556a46 to
aefe288
Compare
Add branch name (revision) to FossID scan code for easier identification of scanned source code. As FossID accepts maximum of 255 characters in scan code, branch name is trimmed to size, that is compliant with this constraint. Signed-off-by: Kamil Bielecki <[email protected]>
kamil-bielecki-bosch
force-pushed
the
add_branch_name_to_fossid_scan_code
branch
from
aefe288 to
30f2c3d
Compare
oheger-bosch
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds branch name (revision) to FossID scan code for easier identification of scanned source code.
As FossID accepts maximum of 255 characters in scan code, branch name is trimmed to size, that is compliant with this constraint.