test: Fix two failing fun tests #8634
Merged
+66
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8634 +/- ##
=========================================
Coverage 67.97% 67.98%
Complexity 1005 1005
=========================================
Files 244 244
Lines 7844 7787 -57
Branches 876 876
=========================================
- Hits 5332 5294 -38
+ Misses 2129 2110 -19
Partials 383 383
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Can I push an update for |
This comment was marked as outdated.
This comment was marked as outdated.
fviernau
changed the title
I meanwhile combined them in this PR. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sschuberth
requested changes
May 8, 2024
| @@ -25,10 +25,12 @@ import io.kotest.matchers.result.shouldBeSuccess | |||
| import io.kotest.matchers.shouldBe | |||
|
|
|||
| import java.time.Instant | |||
| import kotlinx.serialization.encodeToString | |||
clients/osv/src/funTest/assets/vulnerabilities-by-commit-expected-result.json
Show resolved
Hide resolved
Signed-off-by: Frank Viernau <[email protected]>
Signed-off-by: Frank Viernau <[email protected]>
sschuberth
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.