Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): Do not push Docker images for pull requests #8584

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

mnonnenmacher
Copy link
Member

Disable pushing of Docker images for the docker-build workflow if it was triggered by a pull request. For pull requests the workflow should only verify that the Docker build works, but not publish any images.

Disable pushing of Docker images for the `docker-build` workflow if it
was triggered by a pull request. For pull requests the workflow should
only verify that the Docker build works, but not publish any images.

Signed-off-by: Martin Nonnenmacher <[email protected]>
@mnonnenmacher mnonnenmacher requested a review from a team as a code owner April 28, 2024 16:10
@sschuberth sschuberth enabled auto-merge (rebase) April 28, 2024 16:17
Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.70%. Comparing base (044358a) to head (dde2768).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8584   +/-   ##
=========================================
  Coverage     67.70%   67.70%           
  Complexity     1007     1007           
=========================================
  Files           246      246           
  Lines          7924     7924           
  Branches        883      883           
=========================================
  Hits           5365     5365           
  Misses         2176     2176           
  Partials        383      383           
Flag Coverage Δ
funTest-non-docker 34.71% <ø> (ø)
test 37.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sschuberth sschuberth merged commit d3ddb4d into main Apr 28, 2024
22 checks passed
@sschuberth sschuberth deleted the docker-pr-no-push branch April 28, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants