Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static HTML report: Improve the ordering of issues #8570

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

fviernau
Copy link
Member

@fviernau fviernau commented Apr 25, 2024

Adjust the issue summary table such that issues are ordered from ERROR to HINT within each table row.

Found in context of: #7921.

@fviernau fviernau requested a review from a team as a code owner April 25, 2024 14:21
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.70%. Comparing base (6a84fa2) to head (7a51ccd).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8570   +/-   ##
=========================================
  Coverage     67.70%   67.70%           
  Complexity     1007     1007           
=========================================
  Files           246      246           
  Lines          7924     7924           
  Branches        883      883           
=========================================
  Hits           5365     5365           
  Misses         2176     2176           
  Partials        383      383           
Flag Coverage Δ
funTest-docker 66.49% <ø> (ø)
funTest-non-docker 34.71% <ø> (ø)
test 37.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -60,6 +60,10 @@ scopes:
- 0
issue_resolutions:
- _id: 0
message: "Example error, resolved."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message: s/vizualization/visualization/

@fviernau fviernau force-pushed the static-html-issues-summary-ordering branch from 467c46d to 310f898 Compare April 25, 2024 14:37
Add issues (analyzer, scanner) for each severity plus a resolved one to
the static HTML test input, to prepare for changing the visualization
of these. Update the assets for the evaluated model and Opossum reporter
for consistency.

Signed-off-by: Frank Viernau <[email protected]>
Adjust the issue summary table (rows), so that errors come first, then
warning, then hints.

Signed-off-by: Frank Viernau <[email protected]>
@fviernau fviernau force-pushed the static-html-issues-summary-ordering branch from 310f898 to 7a51ccd Compare April 25, 2024 14:44
@fviernau fviernau requested a review from sschuberth April 25, 2024 14:44
@fviernau fviernau enabled auto-merge (rebase) April 25, 2024 14:44
Copy link
Contributor

@heliocastro heliocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@fviernau fviernau merged commit e844f82 into main Apr 26, 2024
22 checks passed
@fviernau fviernau deleted the static-html-issues-summary-ordering branch April 26, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants