feat(model): Allow configuring further PostgreSQL connection parameters #8544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschuberth
reviewed
Apr 19, 2024
fviernau
force-pushed
the
model-extend-pg-connection-paramas-config
branch
from
fb092bc to
49dbb24
Compare
fviernau
force-pushed
the
model-extend-pg-connection-paramas-config
branch
2 times, most recently
from
a90419a to
001b125
Compare
sschuberth
reviewed
Apr 19, 2024
The implementation has been done based on [1]. Fixes #8543. [1]: eclipse-apoapsis/ort-server@f0f601e Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
model-extend-pg-connection-paramas-config
branch
from
001b125 to
30c4308
Compare
sschuberth
reviewed
Apr 19, 2024
| @@ -382,9 +382,6 @@ | |||
| "sslrootcert": { | |||
| "type": "string" | |||
| }, | |||
| "parallelTransactions": { | |||
There was a problem hiding this comment.
Please add to the commit message that this is a fixup for f7dd719 which removed the use of this parameter.
fviernau
force-pushed
the
model-extend-pg-connection-paramas-config
branch
from
30c4308 to
9ea7106
Compare
This is a fixup for f7dd719 which removed the use of this parameter. Signed-off-by: Frank Viernau <[email protected]>
The TODO comment refers to a large amount of configuration parameters which are likely not supposed to be added in their entirety. So, drop the comment as there seems little value to have it. Further parameters will be added when need arises. Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
model-extend-pg-connection-paramas-config
branch
from
9ea7106 to
d8eef61
Compare
sschuberth
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation has been done based on 1.
Fixes #8543.