Small improvements to exception mapping data #8162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8162 +/- ##
=========================================
Coverage 67.16% 67.16%
Complexity 2052 2052
=========================================
Files 358 358
Lines 17166 17166
Branches 2462 2462
=========================================
Hits 11530 11530
Misses 4613 4613
Partials 1023 1023
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sschuberth
force-pushed
the
exception-mapping-imps
branch
from
afd074e to
74bb6d9
Compare
|
BTW, I've filed an issue to be able to get this information automatically in the future. |
tsteenbe
requested changes
Jan 24, 2024
There was a problem hiding this comment.
@sschuberth Could you please update the commit message of "feat(exception-mapping): Add Autoconf-exception-generic*" to include links as evidence for the statement "These are analog to the non-generic ones."?
Sorting the lines would break the YAML list nesting. Signed-off-by: Sebastian Schuberth <[email protected]>
The examples from [1] link to `GPL-2.0-only`. [1]: https://spdx.org/licenses/Asterisk-exception.html Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
exception-mapping-imps
branch
from
74bb6d9 to
f3551c6
Compare
These are analog to the non-generic ones, see [1] and [2]. [1]: https://spdx.org/licenses/Autoconf-exception-generic.html [2]: https://spdx.org/licenses/Autoconf-exception-generic-3.0.html Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
exception-mapping-imps
branch
from
f3551c6 to
c547bf1
Compare
tsteenbe
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.